Thanks to visit codestin.com
Credit goes to github.com

Skip to content

No longer possible to specify relay without port #236

@max-baz

Description

@max-baz

This is really a minor issue, just want to leave it for you to make things consistent at some point.

Previously it was possible to specify relay as address only (IP address or relay.example.com), and if no port was specified it would default to 9009.

Now it fails with an error "bad relay address" if you don't specify the port, so the fallback to 9009 no longer works.

I leave it up to you to decide what is better, require port (and remove fallback) or allow specifying relay address without port.

croc/src/croc/croc.go

Lines 355 to 363 in 81ad30c

host, port, err := net.SplitHostPort(address)
if err != nil {
log.Errorf("bad relay address %s", address)
continue
}
// Default port to :9009
if port == "" {
port = "9009"
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions