BMS: Use TI driver functions to init GPIO pins #77
+47
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to get BMS to consistently ACK from SAMV71 master for now. More research needs to be done to figure out why.
3 tasks
dqwed01
reviewed
Nov 1, 2025
| static const SystemStatusResp_t sSystemStatus = { | ||
| .runtime = 0x12, | ||
| .fw_version = 0xA, | ||
| .runtime = 0xFE, |
Collaborator
There was a problem hiding this comment.
Do we know what each hex represents in this context, is it referenced in the datasheet ? If so add a comment what each hex/bit represents.
Contributor
Author
There was a problem hiding this comment.
Whoops I gotta get better at checking the diff. These don't mean anything they are like for BMS or something. Just random numbers atm I just use it for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (tell us what you changes or added or removed please)
This seems to get BMS to consistently ACK from SAMV71 master for now. More research needs to be done to figure out why.
At this point I've come in a tried this 3 times this week and it seems to just work. Even tested with the CLion debugger on the samv71 and was able to see the values I'm returning in the debugger. Again no idea why. As far as I can tell the TI driver just casts the register to a volatile pointer.
How to test (if any tests done)
Tested with logic analyzer with SAMV71 as master and with debugger
Checklist