Adding a command and help for the Google org policy #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs done. Testing now. |
|
Tested the listed commands. This is good to go. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality for managing Google organization policies related to service account key creation, specifically the iam.disableServiceAccountKeyCreation policy. The changes also migrate the templating system from a custom implementation to EJS for better template handling.
- Added a new command
game:android:apiKey:policyto get and set Google organization policies - Replaced custom markdown templating with EJS templating system
- Added API methods to enforce and revoke the service account key creation policy
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/commands/game/android/apiKey/policy.tsx |
New command implementation for managing Google org policies |
src/api/index.ts |
Added API methods for enforcing and revoking policies |
src/types/api.ts |
Extended GoogleStatusResponse with policy-related fields |
src/components/common/Markdown.tsx |
Replaced custom templating with EJS |
| Multiple markdown files | Updated from .md to .md.ejs with EJS syntax |
test/commands/game/android/apiKey/policy.test.ts |
Basic test file for the new command |
package.json |
Added new command to the files array |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Thanks for the great spots Copilot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Whats changed