[SHRINKWRAP-542] Removing unnecessary loggers #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrberan
reviewed
Aug 6, 2024
| import java.nio.channels.SeekableByteChannel; | ||
| import java.nio.charset.StandardCharsets; | ||
| import java.util.logging.Logger; | ||
|
|
There was a problem hiding this comment.
Just a matter of taste, but I believe the extra space helps readability of certain groups of imported classes, especially from the same groupID. As such, I'd like the extra space to stay. WDYT @khermano ?
There was a problem hiding this comment.
Sure. I already pushed changes. Thanks for the review.
petrberan
reviewed
Aug 6, 2024
| @Override | ||
| public void setId(final String id) throws IllegalArgumentException { | ||
| this.getArchive().setId(id); | ||
|
|
There was a problem hiding this comment.
Probably just syntax fix from the IDE itself, I think we can keep these lines just to keep the diff clean as removing them doesn't really correspond with removing loggers
22abe83 to
f70605a
Compare
petrberan
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/SHRINKWRAP-542