feat(modal)- Return closable instance #2159
Conversation
🦋 Changeset detectedLatest commit: e1b3f1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| return super.open(config); | ||
| } | ||
|
|
||
| public close<TReason = any>( |
There was a problem hiding this comment.
Is this really needed? Will be inherited from base ModalService, right?
There was a problem hiding this comment.
I have implemented it similar to the open service, should changes be made there too?
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature for programmatically closing modals. The implementation for Angular is solid. However, there are a few points of improvement for the React and Vue wrappers to ensure consistency and robustness. I've noted a potential runtime error in the Vue implementation and suggested aligning the React and Vue APIs with the other frameworks by exposing a closeModal function.
|
💡 What is the current behavior?
Currently there is not close function for modal when used in angular, react and vue
GitHub Issue Number: #
JIRA- IX-1318
🆕 What is the new behavior?
Modal now has a close function which can be accessed from outside to close modal based on custom logic.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support