Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Discard of stdin doesn't seem to work #194

@medikoo

Description

@medikoo

As I test in latest installation of ora, pressing enter creates a new line and duplicates a progress line, which gives impression that discard of stdin is not effective.

As I investigated it stopped working after #163 was taken.

Additional logical issues I've spotted in codebase:

  • ourEmit looks as dead code. this function seem to be never used (do I miss something?)
  • SINGINT handling condition seems logically incorrect, however it's not an issue, as ora loading signal-exit (through its dependencies) ensures there's always some listener to SIGINT event attached. Nonetheless condition should start with if (process.listenerCount('SIGINT')) { and not if (process.listenerCount('SIGINT') === 0) {

I'm not proposing a PR, as I'm not sure how conversion to bl should be handled (whether implementation should stick to it, but fix its setup, or revert to mute-stream where it worked)

/cc @aminya @stroncium

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions