-
-
Couldn't load subscription status.
- Fork 284
Open
Description
As I test in latest installation of ora, pressing enter creates a new line and duplicates a progress line, which gives impression that discard of stdin is not effective.
As I investigated it stopped working after #163 was taken.
Additional logical issues I've spotted in codebase:
ourEmitlooks as dead code. this function seem to be never used (do I miss something?)SINGINThandling condition seems logically incorrect, however it's not an issue, asoraloadingsignal-exit(through its dependencies) ensures there's always some listener toSIGINTevent attached. Nonetheless condition should start withif (process.listenerCount('SIGINT')) {and notif (process.listenerCount('SIGINT') === 0) {
I'm not proposing a PR, as I'm not sure how conversion to bl should be handled (whether implementation should stick to it, but fix its setup, or revert to mute-stream where it worked)
/cc @aminya @stroncium
Metadata
Metadata
Assignees
Labels
No labels