[ENH] Simplify BaseEstimator._get_fitted_params() and BaseParamFitter inheritance of that method
#5633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
_get_fitted_params()_get_fitted_params()
fkiraly
requested changes
Dec 22, 2023
Collaborator
There was a problem hiding this comment.
As suggested in this comment: #5630 (comment)
Could we try:
- deleting the
_get_fitted_paramsfromBaseParamFitter - make changes in the
BaseEstimatorinstead?
Alteratively, it might turn nout that we do need an override in BaseParamFitter, in that case we need to spell out the reason why we do - so in either case it would be useful to understand the inheritance tree here and the changes in logic this causes.
More details are discussed in #5630 (comment)
fkiraly
previously approved these changes
Jan 10, 2024
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
I moved your change up to BaseEstimator now - hope that's fine?
Btw, this should eventually be refactored into scikit-base, so it would be nice if you could make the same change there!
_get_fitted_params()BaseEstimator._get_fitted_params() and BaseParamFitter inheritance of that method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Relates to discussions had on #5630
What does this implement/fix? Explain your changes.
See #5630 (comment)
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktimeroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.