Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Release v0.9.0 #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 8, 2021
Merged

Release v0.9.0 #1682

merged 16 commits into from
Dec 8, 2021

Conversation

@mloning
Copy link
Contributor

@mloning mloning commented Dec 3, 2021 •
edited by lmmentel
Loading

Reference Issues/PRs

https://github.com/alan-turing-institute/sktime/milestone/9

What does this implement/fix? Explain your changes.

  • update README
  • update version
  • remove deprecated functionality
  • update all contributors
  • update changelog

fkiraly
fkiraly requested changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In response to @mloning's slack post that he plans to do this tomorrow morning.

I think this is too rushed! Let's do at least one day of feature freeze, as we have agreed.

There are further a number of fixes to bugs in the milestone
https://github.com/alan-turing-institute/sktime/pulls?q=is%3Aopen+is%3Apr+milestone%3Av0.9.0
which haven't gone in yet. They are done, just need to be quickly looked at and merged.

I am against releasing without 1 day feature freeze and without having gone at least through the bugfix PRs.

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 3, 2021 •
edited
Loading

FYI @lmmentel - in particular I don't think the 0.9.0 release should happen without all tests passing.

Currently, due to some problem with CI/CD that we don't fully understand, 5 tests fail without the CI/CD noticing (@lmmentel, can you please confirm this?). This can be checked by local testing.
In line with "all tests must pass" policy, we need to fix those before 0.9.0. Those fixes are part of the unreviewed PR in the milestone.

@lmmentel
Copy link
Contributor

lmmentel commented Dec 4, 2021

FYI @lmmentel - in particular I don't think the 0.9.0 release should happen without all tests passing.

Currently, due to some problem with CI/CD that we don't fully understand, 5 tests fail without the CI/CD noticing (@lmmentel, can you please confirm this?). This can be checked by local testing. In line with "all tests must pass" policy, we need to fix those before 0.9.0. Those fixes are part of the unreviewed PR in the milestone.

I rerun the test suite locally using this branch and a fresh venv and all seems good:

================================================================== 9075 passed, 546 warnings in 618.44s (0:10:18) ===================================================================

fkiraly
fkiraly approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving now (as per discussion in slack), priority bugfixes are merged, other items solved or moved to next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fkiraly fkiraly fkiraly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mloning @fkiraly @lmmentel