Revise phrasing for specific reviews in PR task list #9328
Conversation
to ask for someone specific. [ci skip]
There was a problem hiding this comment.
Is this still under discussion? I personally very much like the check box to exist. There are two reasons:
- Even though I get pinged on everything, it's useful to know if someone wants my input, specifically. Then I know both that I cannot just wait for someone else to review it, and that they perceive me as a relative expert, which (might) change how I review the changes
- It reminds me to ping people that don't get pinged on everything, say, e.g., Mihai for resample changes
It's ok if that opinion is overruled, I can just remember on my own to request certain reviewers.
|
Sure, we can discuss. I'm happy to keep it if we can rephrase in a way that makes it clear that if you know who to tag, you should do so, and if you don't know who to tag, you don't have to. |
|
How about "Mark PR as Ready for Review. If you have a specific reviewer in mind, tag them." |
I like the second half, but some folks don't initially submit PRs as draft and might be confused about what "Mark PR as Ready for Review" means. Maybe that needs to be a separate bullet to clarify? Or just leave that part out? |
|
I'm fine leaving it out, I only really cared about the second part |
|
So instead of removing, rename to the following? - [ ] If you have a specific reviewer in mind, tag them. |
Yes, that's the proposal. Is that clear enough to you? |
[ci skip]
|
Sounds good. I added a commit to that effect. Should you accept this PR, please "squash and merge". Thanks for the reviews! |
|
I'll wait and see if @tapastro wants to comment, but the new proposal looks fine to me. |
|
I'll go ahead and get this merged now. We can always revise again later if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9328 +/- ##
=======================================
Coverage 74.69% 74.69%
=======================================
Files 369 368 -1
Lines 37117 37106 -11
=======================================
- Hits 27723 27717 -6
+ Misses 9394 9389 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the feedback! |
…9328) Co-authored-by: Melanie Clarke <[email protected]>
…9328) Co-authored-by: Melanie Clarke <[email protected]>
There is no JIRA ticket. As discussed on Slack with @tapastro and @melanieclarke , the first checkbox below is no longer needed.
Tasks
request a review from someone specific, to avoid making the maintainers review every PRBuild 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files