fixed bugs reported in git issue 9572 #9575
Conversation
|
I'm going to leave this at draft for now - I'd like to keep the FITSDiff workaround for the build transition. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9575 +/- ##
==========================================
- Coverage 80.37% 80.37% -0.01%
==========================================
Files 367 367
Lines 37259 37260 +1
==========================================
Hits 29946 29946
- Misses 7313 7314 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
It looks like you have addressed only one of the two reported bugs so far. The changes here fix the crash for all-NaN images but differences in the number of NaNs in tables is still uncaught.
Test data is jw01345066001_05101_00003_nrs1_x1d.fits and jw01345066001_05101_00003_nrs1_x1d_bad.fits. I set the whole wavelength array to NaN in the "bad" file -- stfitsdiff currently reports no differences.
There was a problem hiding this comment.
The test suite is looking good, but I think we could still get a few more things covered, since we have some time to work on this. In particular, as Robert mentioned this morning, it looks like there are a few branches not covered in the table diff -- can you see if you can catch those?
Resolves JP-4041
Closes #9572
This PR addresses bugs reported in issue 9572.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files