Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JP-3889: Explain how source position is computed in source catalog step docs #9656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2025
Merged

JP-3889: Explain how source position is computed in source catalog step docs #9656

merged 5 commits into from
Jul 21, 2025

Conversation

@emolter
Copy link
Collaborator

@emolter emolter commented Jul 16, 2025 •
edited
Loading

Resolves JP-3889

Closes #9200

This PR clarifies the intent of the source position centroids reported in the source catalog output by the SourceCatalogStep, including a disclaimer that uncertainty estimation is not attempted.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@emolter emolter added this to the Build 12.1 milestone Jul 16, 2025
@emolter emolter marked this pull request as ready for review July 16, 2025 18:16
@emolter emolter requested a review from a team as a code owner July 16, 2025 18:16
@emolter emolter requested a review from drlaw1558 July 16, 2025 18:17
@codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@e876ab7). Learn more about missing BASE report.
⚠️ Report is 336 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9656   +/-   ##
=======================================
  Coverage        ?   80.37%           
=======================================
  Files           ?      367           
  Lines           ?    37265           
  Branches        ?        0           
=======================================
  Hits            ?    29951           
  Misses          ?     7314           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pllim
pllim reviewed Jul 16, 2025
View reviewed changes
melanieclarke
melanieclarke reviewed Jul 21, 2025
View reviewed changes
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, other than a very small typo.

I think the clarification here is helpful, and we can go ahead and get it in. Up to INS if it also closes the ticket, or if more work is needed.

@emolter emolter enabled auto-merge (squash) July 21, 2025 18:13
@emolter emolter merged commit adb89b3 into spacetelescope:main Jul 21, 2025
27 checks passed
@stscijirahub stscijirahub mentioned this pull request Jul 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim left review comments

@melanieclarke melanieclarke melanieclarke approved these changes

@drlaw1558 drlaw1558 Awaiting requested review from drlaw1558

Assignees

No one assigned

Labels

documentation no-changelog-entry-needed

Projects

None yet

Milestone

Build 12.1

Development

Successfully merging this pull request may close these issues.

A help desk user's suggestions to improve output from source finding

3 participants

@emolter @pllim @melanieclarke