Fix labelIdle localization bug to show correct label #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2024 19:39
Check if placeholder was passed from livewire component
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version: 1.2.3
PHP: 8.2
Laravel 11
Issue #10 introduced a bug for the labelIdle property.
The value from the localization file was overwritten by the second call to setOptions, causing it to always display the default English value.
Drag & Drop your files or <span class="filepond--label-action"> Browse </span>livewire-filepond/resources/views/upload.blade.php
Lines 81 to 85 in 8e69e56
This PR checks whether a custom placeholder value was passed from the component in order to determine if the second call should be triggered.