Sighting report

make uninstall does not remove Python scripts (spdk-rpc, spdk-cli, etc.). The location where make install places the scripts has changed on Ubuntu since commit 52d2355 ("python: add executable scripts and readme"). Now it is <PREFIX>/local/bin instead of <PREFIX>/bin. However, the uninstall rule still assumes the location is <PREFIX>/bin.

uninstall:
        $(Q)rm -rf $(DESTDIR)/$(pylibdir)/spdk*
        $(Q)rm -f $(DESTDIR)/$(bindir)/spdk-rpc
        $(Q)rm -f $(DESTDIR)/$(bindir)/spdk-sma
        $(Q)rm -f $(DESTDIR)/$(bindir)/spdk-cli

bindir is defined as bindir?=$(CONFIG_PREFIX)/bin.

Expected Behavior

make uninstall removes spdk-rpc, spdk-cli, etc from <PREFIX>/local/bin

Current Behavior

make uninstall attempts to remove spdk-rpc, spdk-cli, etc from <PREFIX>/bin

Steps to Reproduce

$ ./configure --prefix=/tmp/spdk && make && make install && make uninstall
$ ls /tmp/spdk/local/bin/
spdk-cli  spdk-mcp  spdk-rpc  spdk-sma

Context (Environment including OS version, SPDK version, etc.)

OS: Ubuntu 22.04, 24.04
SPDK: v26.01-pre-94-g81e390b193ad