Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mach-kernel
Copy link
Contributor

@mach-kernel mach-kernel commented Oct 21, 2025

πŸ“ Summary

See diff. Fixes #7632.

@mach-kernel mach-kernel requested a review from a team as a code owner October 21, 2025 13:46
Copilot AI review requested due to automatic review settings October 21, 2025 13:46
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

βœ… Pull with Spice Passed

Passing checks:

  • βœ… Title meets minimum length requirement (10 characters)
  • βœ… Has at least one of the required labels: kind/refactor, kind/bug, kind/enhancement, kind/documentation, kind/optimization, kind/dependencies, kind/endgame, kind/task, kind/performance
  • βœ… No banned labels detected
  • βœ… Has at least one assignee: mach-kernel

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates snapshot tests to reflect a change in the physical query plan structure where BytesProcessedExec has been moved to wrap GlobalLimitExec instead of being wrapped by it. This represents a reordering of execution operators in the physical plan.

Key Changes

  • Reordered execution operators in the physical plan: BytesProcessedExec now appears before GlobalLimitExec in the operator tree
  • Updated snapshot test expectations to match the new query plan structure

@mach-kernel mach-kernel self-assigned this Oct 21, 2025
@mach-kernel mach-kernel added the kind/task A sub-task of an enhancement (only used for issues, not PRs) label Oct 21, 2025
lukekim
lukekim previously approved these changes Oct 21, 2025
Copilot AI review requested due to automatic review settings October 21, 2025 15:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@mach-kernel mach-kernel enabled auto-merge October 21, 2025 16:57
@mach-kernel mach-kernel added this pull request to the merge queue Oct 21, 2025
Merged via the queue into trunk with commit 8a04c29 Oct 21, 2025
58 of 59 checks passed
@mach-kernel mach-kernel deleted the mach/bytes-processed-snapshots branch October 21, 2025 17:41
@mach-kernel mach-kernel modified the milestone: v1.8.3 Oct 24, 2025
mach-kernel added a commit that referenced this pull request Oct 26, 2025
* accept: limits push down lower after bytesprocessed allows passthrough

* accept: limits push down lower after bytesprocessed allows passthrough
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/task A sub-task of an enhancement (only used for issues, not PRs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration tests are failing due to snapshot changes for GlobalLimit/BytesProcessedExec ordering

2 participants