Remove 'PostApplyCandidateGeneration' #7288
Merged
+3
−493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the PostApplyCandidateGeneration wrapper that was previously used to add filter and projection support to candidate generation methods. The removal is justified by the migration to using the text_search UDTF in HTTP, making this post-processing logic redundant.
- Completely removes the
post_apply.rsfile containingPostApplyCandidateGenerationimplementation - Removes module declaration and imports of the post-apply functionality
- Simplifies the candidate generation creation to use
TextSearchCandidatedirectly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/search/src/generation/post_apply.rs | Entire file deleted, removing the PostApplyCandidateGeneration implementation and its tests |
| crates/search/src/generation.rs | Removes the post_apply module declaration |
| crates/runtime/src/search/full_text/mod.rs | Removes imports and usage of PostApplyCandidateGeneration, simplifies candidate generation creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
phillipleblanc
approved these changes
Sep 25, 2025
kczimm
pushed a commit
that referenced
this pull request
Sep 29, 2025
* Remove 'PostApplyCandidateGeneration' * clppy * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
text_searchUDTF, the logic ofPostApplyCandidateGenerationis not needed.