chore(server): remove redundant okta_site field from organizations #7951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschmatzler
approved these changes
Aug 1, 2025
Organizations.sso_organization_id serves the same purpose as organizations.okta_site. This change eliminates the redundancy by: - Updating Tuist.OAuth.Okta.config_for_organization to use sso_organization_id instead of okta_site - Removing okta_site field from Organization schema and changesets - Removing unused Environment APIs (okta_client_id_for_organization_id, okta_client_secret_for_organization_id) - Creating migration to drop okta_site column - Updating all tests to use sso_organization_id consistently This simplifies the data model and eliminates potential confusion between the two fields.
4bd8f35 to
80beca0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm noticed we already had
okta_sitein the organizations table but assso_organization_id. This PR removes that extra column, and also updates the logic to get the OAuth2 info for a given organization to read the values from the organization entity.Summary (Claude-generated)
This PR removes the redundant
okta_sitefield from the organizations table. Thesso_organization_idfield serves the same purpose and eliminates confusion between the two fields.Changes
Database Changes
okta_sitecolumn from organizations tableokta_sitefield and referencesCode Changes
Tuist.OAuth.Okta.config_for_organization/1to usesso_organization_idinstead ofokta_siteokta_client_id_for_organization_id/2andokta_client_secret_for_organization_id/2okta_sitereferencesokta_sitefieldTest Changes
sso_organization_idokta_sitereferencesokta_siteparameterTest Results
Breaking Changes
None - this is purely an internal data model simplification. The public API remains unchanged.