[tailscale] net/http: add SetResponseWriteEnforcer #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
reviewed
Oct 14, 2025
| @@ -0,0 +1,100 @@ | |||
| package http_test | |||
bradfitz
approved these changes
Oct 14, 2025
|
oh, but put |
bradfitz
reviewed
Oct 14, 2025
2907351 to
fd907a2
Compare
To use with Trackers, inject the Tracker into the Request context with http.Server.BaseContext so that it is accessible in the SetResponseWriteEnforcer callback. Close the injected Tracker in a defer at the first layer of handle. Updates tailscale/corp#7821 Updates #55
fd907a2 to
02dc1d8
Compare
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Oct 17, 2025
Updates tailscale/go#140 Updates tailscale/go#142 Updates tailscale/go#138 Change-Id: Id25b6fa4e31eee243fec17667f14cdc48243c59e Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Oct 17, 2025
Updates tailscale/go#140 Updates tailscale/go#142 Updates tailscale/go#138 Change-Id: Id25b6fa4e31eee243fec17667f14cdc48243c59e Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
added a commit
to tailscale/tailscale
that referenced
this pull request
Oct 17, 2025
Updates tailscale/go#140 Updates tailscale/go#142 Updates tailscale/go#138 Change-Id: Id25b6fa4e31eee243fec17667f14cdc48243c59e Signed-off-by: Brad Fitzpatrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea with this change is to inject the Tracker into the Request context with http.Server.BaseContext so that it is accessible in the SetResponseWriteEnforcer callback. Close the injected Tracker in a defer at the first layer of handle.
This is only adding enforcement at the time of WriteHeader, which is often implicitly called during the first Write. But this enforcement wouldn't catch the following pattern:
Updates tailscale/corp#7821
Updates #55