Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid registry.lists when an overridable action would suffice #1905

@FireChickenProductivity

Description

It is recommended that we reduce dependency on registry.lists outside of the context of debugging. We are still using registry.lists for common_functions.py. I believe we could avoid that by having an overridable action return the list. At some point, we should probably go over all the uses of registry.lists and see which we can remove.

registry.lists:

functions_common.py usage seems incorrect

libraries_gui.py seems incorrect

snippets.py seems incorrect

talon_repl.talon seems fine

talon_helpers.py seems fine

help.py seems fine

The imgui code here that uses registry.lists to find the currently active version of a list and manually read values out of it, should define / call an overridable action instead.

Originally posted by @lunixbochs in #1090

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions