Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mo271
Copy link
Contributor

@mo271 mo271 commented Aug 20, 2025

No description provided.

@mo271
Copy link
Contributor Author

mo271 commented Aug 20, 2025

WIP: still needs fixes in some files to build. (And then deprecation warnings, etc.)

@YaelDillies
Copy link
Collaborator

Nooo, sorry, I'm almost done bumping myself πŸ˜…

@mo271
Copy link
Contributor Author

mo271 commented Aug 20, 2025

Nooo, sorry, I'm almost done bumping myself πŸ˜…

No worries, just go ahead with your pr then, especially if you are further along

@YaelDillies
Copy link
Collaborator

In fact, we barely duplicated effort as I spent a lot of time dealing with the deprecations and new simp normal forms, while you have fixed the proofs that gave actual errors. I will copy-paste the relevant changes to my WIP commit.

@mo271
Copy link
Contributor Author

mo271 commented Aug 20, 2025

@YaelDillies The build should be fixed now, I won't work on the warning and simp hints when you are already doing this.
Seems like there are quite a few:

~/pfr (master)> lake build | grep warning | wc
    284    2409   26223

@mo271
Copy link
Contributor Author

mo271 commented Aug 22, 2025

ok, should be good now: builds and all deprecation warnings are gone.

@mo271 mo271 marked this pull request as ready for review August 22, 2025 07:51
@YaelDillies
Copy link
Collaborator

Oh, I realise we don't have CI setup for PRs from forks... Let me investigate quickly.

@YaelDillies YaelDillies merged commit 9a587eb into teorth:master Aug 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants