Update _tt_cross.py #591
Open
Update _tt_cross.py #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request for Maxvol Adjustment Issue Hi, I previously discussed the maxvol adjustment issue, and after talking with Zongyi Li, I think my implementation is correct. Following the suggestion, I am submitting this pull request for review. Please let me know if there are any areas that need improvement or further clarification. Thank you for your guidance and support!
|
Thanks @dontempty - it looks like the tests fail, seems the update is leading to an index out of bounds. |
|
I have identified and corrected the mistakes from earlier. I would
appreciate it if you could review it again.
2025년 1월 21일 (화) 오후 2:48, Jean Kossaifi ***@***.***>님이 작성:
… Thanks @dontempty <https://github.com/dontempty> - it looks like the
tests fail, seems the update is leading to an index out of bounds.
—
Reply to this email directly, view it on GitHub
<#591 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFB77UIHBX43IOM7YHWZOLT2LXNRXAVCNFSM6AAAAABVD7VF7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBTG4YTCMJYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
=======================================
Coverage 87.98% 87.99%
=======================================
Files 132 132
Lines 7848 7853 +5
=======================================
+ Hits 6905 6910 +5
Misses 943 943 ☔ View full report in Codecov by Sentry. |
modify np.sum => tl.sum
|
@zongyi-li if you have some time to have a look! |
reformat by black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Maxvol Adjustment Issue
Hi,
I previously discussed the maxvol adjustment issue #586 , and after talking with Zongyi Li, I think my implementation is correct. Specifically I have accurately implemented the "Remove the projection of v from every element of A.”
Please let me know if there are any areas that need improvement or further clarification.
Thank you for your guidance and support!