common: implement custom allocator support #3892
Open
+45
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Just for future records, this PR is intended to get these issues done:
Initial v1 patch is at: #3859 |
00de6d8 to
321262a
Compare
321262a to
74d016f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements custom heap allocator support in the ThorVG library, allowing users to provide their own memory allocation functions instead of using the standard library allocators.
- Adds a HeapAllocator struct with function pointers for custom malloc, calloc, realloc, and free implementations
- Updates the Initializer::init() method to accept an optional HeapAllocator parameter
- Replaces direct std library calls with calls through the custom allocator
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inc/thorvg.h | Defines HeapAllocator struct and updates init() method signature with allocator parameter |
| src/common/tvgAllocator.h | Updates memory allocation functions to use custom allocator instead of std library calls |
| src/renderer/tvgInitializer.cpp | Stores the provided HeapAllocator in global state during initialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9349d37 to
d2eeb0e
Compare
1187d52 to
a3c338e
Compare
hermet
reviewed
Oct 20, 2025
Member
hermet
left a comment
There was a problem hiding this comment.
@huming2207 I just added comments for aligning the new APIs. Thanks for your contribution.
a3c338e to
37ce00b
Compare
Member
Author
|
@hermet Done. Meanwhile should I mark this PR as ready, or should I leave it as draft? |
657b8f1 to
c09da73
Compare
1971b85 to
db355dd
Compare
37ce00b to
d5aa941
Compare
1b33069 to
9ebd273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hermet
I've just implemented the second version of heap allocator customization support.
I hope it doesn't bring too much trouble to you, but it seems working for me, at least on my PC with the unit test...
I will bring it on to ESP32 with PSRAM-only heap allocator shortly, and see what will happen.
Regards,
Jackson