Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix saturation filter #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2022
Merged

Fix saturation filter #1421

merged 3 commits into from
Mar 9, 2022

Conversation

@devppjr
Copy link
Contributor

@devppjr devppjr commented Mar 9, 2022 •
edited
Loading

We found a bug while testing saturation filter on python3 environment.

saturation function inside thumbor/filters/saturation.py does not have async keyword.

Traceback:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/tornado/web.py", line 1704, in _execute
    result = await result
  File "/usr/local/lib/python3.9/dist-packages/thumbor/handlers/imaging.py", line 97, in get
    return await self.check_image(kw)
  File "/usr/local/lib/python3.9/dist-packages/thumbor/handlers/imaging.py", line 94, in check_image
    return await self.execute_image_operations()
  File "/usr/local/lib/python3.9/dist-packages/thumbor/handlers/__init__.py", line 186, in execute_image_operations
    await self.get_image()
  File "/usr/local/lib/python3.9/dist-packages/thumbor/handlers/__init__.py", line 274, in get_image
    await self.after_transform()
  File "/usr/local/lib/python3.9/dist-packages/thumbor/handlers/__init__.py", line 314, in after_transform
    await self.filters_runner.apply_filters(
  File "/usr/local/lib/python3.9/dist-packages/thumbor/filters/__init__.py", line 121, in apply_filters
    await filter_to_run.run()
  File "/usr/local/lib/python3.9/dist-packages/thumbor/filters/__init__.py", line 214, in run
    results.append(await self.runnable_method(*self.params))
  File "/usr/local/lib/python3.9/dist-packages/thumbor/filters/__init__.py", line 56, in wrapper
    return await filtered_function(self, *args2)
TypeError: object NoneType can't be used in 'await' expression

I also created unit test and docs for saturation filter.

@devppjr devppjr self-assigned this Mar 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devppjr devppjr requested review from heynemann and scorphus March 9, 2022 14:39
@heynemann heynemann merged commit ed31323 into master Mar 9, 2022
@heynemann
Copy link
Member

heynemann commented Mar 9, 2022

Thanks a lot for the PRs!

@devppjr devppjr deleted the fix-saturation-filter branch March 9, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heynemann heynemann Awaiting requested review from heynemann

@scorphus scorphus Awaiting requested review from scorphus

Assignees

@devppjr devppjr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devppjr @heynemann