resizing the watermark relative to image (fixes #874) #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4538291 to
18fbd43
Compare
Contributor
Author
|
should fix #874 |
18fbd43 to
fddcf45
Compare
|
This looks great. |
Contributor
Author
|
anything which needs to be done to get this into thumbor? |
fddcf45 to
554d24c
Compare
Contributor
Author
|
@masom ? 😄 |
|
Changes Unknown when pulling e4dfdb6 on Savar:watermark_with_resize into ** on thumbor:master**. |
two new (optional) parameters added to the watermark filter to resize the watermark relatively to the image it should be placed on see the provided doc file to understand how it works
e4dfdb6 to
bb8d4dc
Compare
Contributor
Author
|
@masom how about that one? |
|
That's great! When will it be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two new (optional) parameters added to the watermark filter to resize
the watermark relatively to the image it should be placed on
see the provided doc file to understand how it works