-
Notifications
You must be signed in to change notification settings - Fork 857
print(), xrange(), unicode(), basestring, exception changes for Python 3 #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cclauss Could you fix the lint error about too many blank lines on |
|
The GitHub web ui does not allow PR authors to squash multiple commits on repos that they do not have write access to. It does however allow repo owners to do "Squash and merge" at the touch of a button. https://help.github.com/articles/about-pull-request-merges/#squash-and-merge-your-pull-request-commits |
|
Gotcha, you are using the github web ui to make all those changes? I don't mind squashing for you. You should know using the GitHub UI does create a repo + branch for you on your account: https://github.com/cclauss/thumbor/tree/patch-1 Once CI is green 🚀 |
|
Yes. I did them all in the web ui. I have tried before the use git at the command line to squash the repo + branch but it only led to frustration. I need to pair program with a git guru someday. If you could squash, that would be a great relief to me. I you want to keep 2e533e9 in place, I have not objections. |
|
Ready for your review. |
|
Thank you @cclauss ! This is a first step toward Thumbor running on Python 3.3+ |
|
Good stuff... Python 3.3 goes EOL next month you should probably shift up one to Python 3.4+. |
|
Yeah, but we currently don't even support python3 at all. |
No description provided.