Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cclauss
Copy link

@cclauss cclauss commented Jul 23, 2017

No description provided.

@masom
Copy link
Contributor

masom commented Aug 23, 2017

@cclauss Could you fix the lint error about too many blank lines on test_base64_hmac_sha1_signer.py and squash into 1 commit?

@cclauss
Copy link
Author

cclauss commented Aug 23, 2017

The GitHub web ui does not allow PR authors to squash multiple commits on repos that they do not have write access to. It does however allow repo owners to do "Squash and merge" at the touch of a button. https://help.github.com/articles/about-pull-request-merges/#squash-and-merge-your-pull-request-commits

@masom
Copy link
Contributor

masom commented Aug 23, 2017

Gotcha, you are using the github web ui to make all those changes?

I don't mind squashing for you. You should know using the GitHub UI does create a repo + branch for you on your account: https://github.com/cclauss/thumbor/tree/patch-1

Once CI is green 🚀

@masom
Copy link
Contributor

masom commented Aug 23, 2017

@cclauss I don't think 2e533e9 should be applied.

Flake8 allows us to keep things consistent and match what the python community is expecting.

@cclauss
Copy link
Author

cclauss commented Aug 23, 2017

Yes. I did them all in the web ui. I have tried before the use git at the command line to squash the repo + branch but it only led to frustration. I need to pair program with a git guru someday. If you could squash, that would be a great relief to me.

I you want to keep 2e533e9 in place, I have not objections.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 84.428% when pulling c541eb8 on cclauss:patch-1 into 2e9b909 on thumbor:master.

@coveralls
Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage decreased (-0.5%) to 84.428% when pulling c541eb8 on cclauss:patch-1 into 2e9b909 on thumbor:master.

@cclauss
Copy link
Author

cclauss commented Aug 24, 2017

Ready for your review.

@masom
Copy link
Contributor

masom commented Aug 24, 2017

Thank you @cclauss ! This is a first step toward Thumbor running on Python 3.3+

@masom masom merged commit 6066995 into thumbor:master Aug 24, 2017
@cclauss cclauss deleted the patch-1 branch August 24, 2017 13:44
@cclauss
Copy link
Author

cclauss commented Aug 24, 2017

Good stuff... Python 3.3 goes EOL next month you should probably shift up one to Python 3.4+.

@masom
Copy link
Contributor

masom commented Aug 24, 2017

Yeah, but we currently don't even support python3 at all.

@Kmaschta Kmaschta mentioned this pull request Jan 5, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants