Allow custom LoaderResult errors #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masom
requested changes
May 30, 2017
|
|
||
| class LoaderResult(object): | ||
|
|
||
| ERROR_NOT_FOUND = 'not_found' |
Contributor
There was a problem hiding this comment.
@gi11es Removing those const would be backward incompatible. For thumbor 6 it should be possible to support both constants and response codes.
elif result.loader_error == LoaderResult.ERROR_TIMEOUT:
# Return a Gateway Timeout status if upstream timed out (i.e. 599)
self._error(504)
elif isinstance(result.loader_error, int):
self._error(result.loader_error)
return
Contributor
Author
|
Fair enough, I'll update the PR to that effect |
b981c1b to
2a666d0
Compare
2a666d0 to
afb1c0e
Compare
Contributor
Author
|
@masom your concerns should be addressed now. |
masom
approved these changes
Jul 5, 2017
5a1fdd5 to
bcaae99
Compare
Being constrained to the hardcoded list is too limiting. Using the actual codes is also less prone to confusion.
bcaae99 to
30b20d5
Compare
Contributor
Author
|
Merge pls? :) |
Contributor
|
Thanks @gi11es for rebasing this. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being constrained to the hardcoded list is too limiting.
Using the actual codes is also less prone to confusion.