Thanks to visit codestin.com
Credit goes to github.com

Skip to content

*: unify the http client #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 22, 2020
Merged

*: unify the http client #2368

merged 6 commits into from
Apr 22, 2020

Conversation

@nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 22, 2020

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

there are many HTTP clients in PD. It's not easy to maintain, we want to supports TLS if the server is configured.

What is changed and how it works?

  • init HTTP client in server
  • replace middleware client
  • replace cluster client
  • replace server/api client

Release note

no need to write

Check List

Tests

  • Unit test

@nolouch nolouch added the component/api HTTP API. label Apr 22, 2020
@nolouch nolouch added this to the v4.0.0-rc.2 milestone Apr 22, 2020
@nolouch nolouch requested review from HunDunDM and rleungx April 22, 2020 08:12
rleungx
rleungx reviewed Apr 22, 2020
View reviewed changes
HunDunDM
HunDunDM reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

HunDunDM
HunDunDM approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor Author

nolouch commented Apr 22, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

/run-all-tests

@sre-bot sre-bot merged commit eb9e209 into tikv:master Apr 22, 2020
@nolouch nolouch deleted the unify-http-client branch April 22, 2020 14:19
@nolouch nolouch added the needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. label Apr 23, 2020
@nolouch
Copy link
Contributor Author

nolouch commented Apr 23, 2020

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Apr 23, 2020

cherry pick to release-3.1 failed

nolouch added a commit to nolouch/pd that referenced this pull request Apr 24, 2020
@nolouch
*: unify the http client (tikv#2368)
c5b33ba 
Signed-off-by: nolouch <[email protected]>
This was referenced Apr 24, 2020
Merged
Closed
rleungx pushed a commit to nolouch/pd that referenced this pull request Apr 26, 2020
@nolouch @rleungx
*: unify the http client (tikv#2368)
1eb391f 
Signed-off-by: nolouch <[email protected]>
@rleungx rleungx mentioned this pull request Apr 26, 2020
Merged
sre-bot pushed a commit that referenced this pull request Apr 26, 2020
@nolouch
*: unify the http client (#2368) (#2381)
e639f0b 
Signed-off-by: nolouch <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HunDunDM HunDunDM HunDunDM approved these changes

@rleungx rleungx rleungx approved these changes

Assignees

No one assigned

Labels

component/api HTTP API. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer.

Projects

None yet

Milestone

v4.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nolouch @sre-bot @HunDunDM @rleungx