Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

@paulfantom
Copy link
Contributor

Description

This allows for better alert routing and silencing in kubernetes environments. In environments where namespace label is not added to metrics, this does nothing.

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

@paulfantom paulfantom requested review from a team as code owners October 21, 2022 11:55
@paulfantom paulfantom force-pushed the include-ns-in-alerts branch from 71aab2d to a6475c9 Compare October 21, 2022 11:55
@alejandrodnm
Copy link
Contributor

I'm fixing the lint in #1709

Copy link
Member

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green

Signed-off-by: Paweł Krupa (paulfantom) <[email protected]>
@paulfantom paulfantom force-pushed the include-ns-in-alerts branch from a6475c9 to da6b3c9 Compare October 21, 2022 14:16
@paulfantom paulfantom enabled auto-merge (rebase) October 21, 2022 15:42
@paulfantom paulfantom disabled auto-merge October 21, 2022 15:42
@paulfantom paulfantom enabled auto-merge (rebase) October 21, 2022 15:42
@paulfantom paulfantom disabled auto-merge October 21, 2022 15:42
@paulfantom paulfantom enabled auto-merge October 21, 2022 15:42
@paulfantom paulfantom merged commit 8a6b7b8 into timescale:master Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants