-
Notifications
You must be signed in to change notification settings - Fork 115
Force revise() after Revise.track #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@timholy I realised in the examples above it's better for the revision to throw if there are issues, so I added a kwarg. |
|
Maybe the default for that kwarg should be |
|
I didn't get why you would not want to revise after tracking? |
|
Sorry I don't follow. |
|
Sorry, nevermind, I was confused about what the kwarg actually did. |
|
I'd be open to removing the kwarg and just making it |
|
Can you expand on what's triggering the throwing? Bad code? Something else? In the OP I'm assuming the error stems from the command ( |
|
Yeah, bad code. Previously
It's better for |
Fixes
PR