-
-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Description
See feedback here
[nitpick] Consider accepting a generic path parameter (e.g., impl AsRef or &Path) instead of &PathBuf to follow Rust conventions and improve flexibility.
pub async fn load(path: &PathBuf) -> Result<Config, Error> {
src/main.rs:79[nitpick] The doc comment still refers to a String; update it to clarify that the field is now a PathBuf.
/// Absolute path of configuration. Defaults to $XDG_CONFIG_HOME/tod.cfg
src/config.rs:664[nitpick] Rather than panicking with expect, consider propagating a descriptive Error so that library code doesn’t unwind unexpectedly in production.
let config_directory = dirs::config_dir().expect("Could not find config directory");
Copilot