Add convenience flag for reverse ssh tunnels #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Didn't format or catch that time_ns was included, but doing that in #566. |
henryiii
reviewed
Nov 23, 2021
|
|
||
| def test_reverse_tunnel(self): | ||
|
|
||
| def serve_reverse_tunnel(queue): |
There was a problem hiding this comment.
FYI, this is not picklable, so can't be forked. Why did this only matter on Python 3.10 + macOS? I have no idea. Anyway, moving it out of the test function should fix the problem.
There was a problem hiding this comment.
That's very strange. Thanks for cleaning that up!
There was a problem hiding this comment.
Think you could look into possibly making the test support forked multiprocessing? Not a big issue if not (the MP part is really due to the test needing both sides of the tunnel, not a normal occurrence).
There was a problem hiding this comment.
Yeah I can definitely look into it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH supports the creation of reverse tunnels using a very similar syntax to normal tunnels. From the man pages:
This PR adds a flag to the
.tunnel()method ofSshMachinethat allows for easy creation of a reversed SSH tunnel