Resolve missing germplasm cvterms in automated testing environment #2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff. Total Coverage: This PR will increase coverage by 0.01%. File Coverage Changes
🛟 Help
|
dsenalik
reviewed
Sep 20, 2025
tripal_chado/config/install/tripal.tripal_content_terms.chado_content_terms.yml
Outdated
Show resolved
Hide resolved
dsenalik
reviewed
Sep 20, 2025
dsenalik
requested changes
Sep 20, 2025
…w ones don't work 🙈
dsenalik
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Issue #2287
Description
In the linked issue @carolyncaron reported that the new germplasm terms used for the core content types (added in #2265) did not make it into the automated test environment 🙈 This PR adds them in.
Testing?
This does not affect any existing tests in Tripal core and only affects the test environment. Right now the best way to test it is to do a careful code review 🤷♀️
Ideally I would also add a test that ensures all the terms represented in the YAML file are in our test environment so this doesn't happen again...