-
Notifications
You must be signed in to change notification settings - Fork 352
NAS-137713 / None / Containers Devices API updates & Cleanup #12768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## NAS-137713 #12768 +/- ##
=============================================
Coverage ? 86.14%
=============================================
Files ? 1812
Lines ? 67207
Branches ? 8225
=============================================
Hits ? 57897
Misses ? 9310
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Removed DISK and RAW device types from enum and interfaces - Simplified instance-disk-form to only support filesystem devices - Removed storage-device-info utils (DISK/RAW only) - Updated device-type-badge, device-actions-menu, and device-description utils - Updated all tests to reflect new device structure
- Added deviceDescription computed signal using getDeviceDescription util - Replaced device().description with deviceDescription() in template - Updated all ixTest attributes and aria-label to use new computed signal
- Added ContainerDeviceType import to instance-disk-form component - Replaced 'FILESYSTEM' string with ContainerDeviceType.Filesystem - Updated test expectations to use enum value
- Changed dtype in ContainerFilesystemDevice from 'FILESYSTEM' to ContainerDeviceType.Filesystem - Changed dtype in ContainerNicDevice from 'NIC' to ContainerDeviceType.Nic - Changed dtype in ContainerUsbDevice from 'USB' to ContainerDeviceType.Usb - Added exhaustiveness checking in getDeviceDescription with never type - Removed unused containerDeviceTypeLabels import
- Updated instance-disks to filter only Filesystem devices (removed DISK/RAW) - Updated instance-usb-devices to use direct equality check instead of includes() - Fixed track keys in templates: changed from device.name to device.id - Updated USB device test mocks to match new interface (usb.vendor_id/product_id) - Fixed test expectations to match new device description format (USB xxxx:yyyy)
- Fixed track key in instance-nics template: changed from device.name to device.id - Updated NIC device test mocks to match new ContainerNicDevice interface - Added required fields: id, trust_guest_rx_filters, nic_attach, mac - Updated test expectations to use nic_attach instead of name (br0/br1)
- Removed blockDeviceNameValidator (for DISK devices) - Removed diskPathValidator (for DISK devices) - Removed rawFilePathValidator (for RAW devices) - Removed corresponding tests for these validators - Removed helptext: deviceTypes.diskTooltip and deviceTypes.rawTooltip - Removed helptext: deviceBadgeTooltips.disk and deviceBadgeTooltips.raw - Removed validator messages: blockDeviceName, diskPathMustStartWithDevZvol, rawFilePathMustStartWithMnt - Kept only validators/helptext for FILESYSTEM devices (containerPathValidator, poolPathValidator)
Removed unused helptext related to removed DISK/RAW device types: - diskFormOptions (virtio, ahci, native, threads, ioUring) - ioBusTooltip - bootFromTooltip
Removed unused helptext items that are not referenced anywhere: - disksLabel, disksSourceLabel, disksDestinationLabel, disksDestinationTooltip - deviceDescriptions.unknownPath Components use inline translations instead of these helptext constants.
The filesystemTooltip in deviceTypes object is not used anywhere. Device tooltips are provided by deviceBadgeTooltips instead.
Fixed 4 test suites that were failing after removing DISK/RAW device types: 1. virtualization-instances.store.spec.ts: Fixed device mocks to use id and dtype 2. virtualization-config.store.spec.ts: Updated subscription expectation from 'virt.global.config' to 'lxc.config' 3. add-usb-device-menu.component.spec.ts: Added missing 'device' property to USB device mock 4. get-device-description.utilts.spec.ts: Completely rewrote tests to only cover FILESYSTEM, NIC, and USB devices All 32 tests now passing.
|
Not updating JIRA ticket https://ixsystems.atlassian.net/browse/NAS-137713 target versions as no JIRA version corresponds to this PR |
|
This PR has been merged and conversations have been locked. |
No description provided.