Jira URL: https://ixsystems.atlassian.net/browse/NAS-138409

Claude finished @themylogin's task —— View job

Review Complete ✅

Todo List

• Read review guidelines
• Examine all changed files
• Search for any remaining references to zfs.pool.scan
• Check for test files that need updates
• Provide comprehensive review feedback

Review Feedback

The changes look clean and straightforward! 🎯 The renaming from zfs.pool.scan to pool.scan has been consistently applied across all relevant files in the UI codebase.

What's working well:

• All WebSocket event subscriptions have been updated correctly (api-event-directory.interface.ts:53, resilver-progress.component.ts:53, resilvering-indicator.component.ts:36, storage-health-card.component.ts:171)
• No remaining references to the old zfs.pool.scan event name in the codebase
• Test files don't need updates since they mock the API service generically without hardcoding event names
• The change is minimal and focused, reducing the risk of introducing bugs

Observations:
The widget-storage.component.ts file also uses pool.scan, but that's accessing the scan property from the Pool interface (line 267), not the WebSocket event, so it's correctly unchanged.

No issues found - this PR is ready to merge! 🚀

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.28%. Comparing base (7c5e6f5) to head (213d23f).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

@@           Coverage Diff           @@
##           master   #12792   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files        1825     1825           
  Lines       67908    67908           
  Branches     8219     8219           
=======================================
  Hits        58595    58595           
  Misses       9313     9313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-138409 is targeted to the following versions which have not received their corresponding PRs: 25.10.1

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.