tsNames: avoid calling private methods in inline methods #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method may be inlined in parent classes, in external code. That results in needing to export the private method so it can be called by the external code, even if it's not supposed to know about it.
Member
|
I have implemented a slightly different solution. Instead of de-inlining the method, I added a Please check if it works for you with clang on Windows. If it does, please close this PR. |
Contributor
Author
|
Yes it seems to be working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method may be inlined in parent classes, in external code. That results in needing to DLL export the private method so it can be called by the external code, even if it's not supposed to know about it.
Moving the inline code into a the C++ file ensures the call is never inlined by the caller, thus not needing to export
AllInstances::Instance().get().