Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Sep 29, 2025

This PR adds a missing

[lints]
workspace = true

entry to uucore/Cargo.toml. As this leads to a lot of clippy warnings in uucore, I disabled all but those from the uninlined_format_args lint, which are fixed in #8769 . Hence the PR is currently expected to fail with warnings from that lint, and it should pass after #8769 is merged The PR should now pass.

@cakebaker cakebaker force-pushed the clippy_lints_workspace_uucore branch from 30c539b to ed9fdb2 Compare September 29, 2025 16:53
@cakebaker cakebaker force-pushed the clippy_lints_workspace_uucore branch from ed9fdb2 to 36b2bd5 Compare September 29, 2025 16:58
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 29, 2025

CodSpeed Performance Report

Merging #8771 will not alter performance

Comparing cakebaker:clippy_lints_workspace_uucore (36b2bd5) with main (0e1a2db)

Summary

✅ 41 untouched
⏩ 64 skipped1

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre sylvestre merged commit 40d0cf0 into uutils:main Sep 29, 2025
98 checks passed
@cakebaker cakebaker deleted the clippy_lints_workspace_uucore branch September 30, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants