chore(mockgen): move model to internal #286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mockgen/model package was importable only for reflect mode. In reflect mode, the generated code would import model, which would then use reflection to export information about types. Reflect mode is not a thing anymore, so there's no need for model to be externally accessible. Move it into an internal package and update all imports *except* those inside the bazel/ directory for the following reasons: - bazel/ is pinned to an older version of this package - those references will be deleted in uber-go#285
Contributor
Author
|
Actually, this requires some discussion. @JacobOaks, if y'all think gob mode is necessary, we should close this PR. |
abhinav
added a commit
to abhinav/gomock
that referenced
this pull request
Oct 4, 2025
Alternative to uber-go#286 Reflect mode has been deprecated in favor of package mode. These functions, which were intended to be called from the generated code in reflect mode, are no longer needed. Delete them.
Contributor
Author
|
Yeah this one is a bad idea. It’ll also block anyone using model import to declare a tool dependency on mockgen cli |
Contributor
|
Yeah, I think we still need this for at Uber as well until we migrate off of gob mode on to the new bazel rules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mockgen/model package was importable only for reflect mode.
In reflect mode, the generated code would import model,
which would then use reflection to export information about types.
Reflect mode is not a thing anymore,
so there's no need for model to be externally accessible.
Move it into an internal package and update all imports
except those inside the bazel/ directory for the following reasons: