-
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
bugSomething isn't workingSomething isn't working
Description
The manual calls to the shared client's ready and disconnect callbacks should be executed on another thread, not on the thread that called start() or stop(), since that is how the normal client works too. Calling these on the caller's thread may lead to deadlocks when a lock is held in the caller's thread and is acquired again in the ready or disconnect callback.
See:
loon/client/src/shared_client.cpp
Line 125 in 6f19a9d
| g_state.on_ready.call(m_client, m_index); |
loon/client/src/shared_client.cpp
Line 154 in 6f19a9d
| g_state.on_disconnect.call(m_client, m_index); |
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working