feat: throw error on unsupported input type, close #2

antfu · antfu · commit b1cb6df2cf10 · 2023-08-15T12:54:40.000+02:00
diff --git a/src/encode.ts b/src/encode.ts
@@ -18,7 +18,12 @@ export function encode(data: QrCodeGenerateData, options?: QrCodeGenerateOptions
 
   const segment = typeof data === 'string'
     ? makeSegments(data)
-    : [makeBytes(data)]
+    : Array.isArray(data)
+      ? [makeBytes(data)]
+      : undefined
+
+  if (!segment)
+    throw new Error(`uqr only supports encoding string and binary data, but got: ${typeof data}`)
 
   const qr = encodeSegments(
     segment,
diff --git a/src/index.ts b/src/index.ts
@@ -1,6 +1,6 @@
 export {
   encode,
-} from './generate'
+} from './encode'
 export {
   renderUnicode,
   renderANSI,
diff --git a/src/render.ts b/src/render.ts
@@ -1,5 +1,5 @@
 import type { QrCodeGenerateData, QrCodeGenerateOptions, QrCodeGenerateUnicodeOptions } from './types'
-import { encode, getDataAt } from './generate'
+import { encode, getDataAt } from './encode'
 
 /**
  * Render QR Code with unicode `█`, `░`
diff --git a/src/svg.ts b/src/svg.ts
@@ -1,4 +1,4 @@
-import { encode } from './generate'
+import { encode } from './encode'
 import type { QrCodeGenerateData, QrCodeGenerateSvgOptions } from './types'
 
 /**
diff --git a/test/index.test.ts b/test/index.test.ts
@@ -1,7 +1,6 @@
 import { describe, expect, it } from 'vitest'
 import { renderUnicode, renderUnicodeCompact } from '../src/render'
-import { encode } from '../src/generate'
-import { renderSVG } from '../src'
+import { encode, renderSVG } from '../src'
 
 describe('should', () => {
   it('generate', () => {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { encode } from './generate'`
	`1`	`+import { encode } from './encode'`
`2`	`2`	`import type { QrCodeGenerateData, QrCodeGenerateSvgOptions } from './types'`
`3`	`3`
`4`	`4`	`/**`