fix(hr): Do not report error if known to not be problematic

dr1rrb · nickrandolph · commit 70ce1dfc2648 · 2025-07-08T15:18:35.000+10:00
diff --git a/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Common.Status.cs b/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Common.Status.cs
@@ -308,6 +308,12 @@ internal void ReportError(Exception error)
 			_onUpdated();
 		}
 
+		internal void ReportWarning(Exception exception)
+		{
+			// This is a warning that does not prevent the HR to complete.
+			// For now, we don't even surface it to the user in any way other than logs (by caller).
+		}
+
 		internal void ReportCompleted()
 		{
 			var result = (_exceptions, IgnoreReason) switch
diff --git a/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.MetadataUpdate.cs b/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.MetadataUpdate.cs
@@ -529,6 +529,14 @@ private static void UpdateApplicationCore(Type[] types)
 					_log.Warn($"Found invalid MetadataUpdateOriginalTypeAttribute for {type}");
 				}
 			}
+			catch (TypeLoadException error)
+			{
+				if (_log.IsEnabled(LogLevel.Warning))
+				{
+					_log.Warn($"Type load error while processing MetadataUpdateOriginalTypeAttribute for {type}", error);
+				}
+				hr?.ReportWarning(error);
+			}
 			catch (Exception error)
 			{
 				if (_log.IsEnabled(LogLevel.Error))

Original file line number	Diff line number	Diff line change
`@@ -308,6 +308,12 @@ internal void ReportError(Exception error)`
`308`	`308`	`_onUpdated();`
`309`	`309`	`}`
`310`	`310`
	`311`	`+ internal void ReportWarning(Exception exception)`
	`312`	`+ {`
	`313`	`+ // This is a warning that does not prevent the HR to complete.`
	`314`	`+ // For now, we don't even surface it to the user in any way other than logs (by caller).`
	`315`	`+ }`
	`316`	`+`
`311`	`317`	`internal void ReportCompleted()`
`312`	`318`	`{`
`313`	`319`	`var result = (_exceptions, IgnoreReason) switch`
Original file line number	Diff line number	Diff line change
`@@ -529,6 +529,14 @@ private static void UpdateApplicationCore(Type[] types)`
`529`	`529`	`_log.Warn($"Found invalid MetadataUpdateOriginalTypeAttribute for {type}");`
`530`	`530`	`}`
`531`	`531`	`}`
	`532`	`+ catch (TypeLoadException error)`
	`533`	`+ {`
	`534`	`+ if (_log.IsEnabled(LogLevel.Warning))`
	`535`	`+ {`
	`536`	`+ _log.Warn($"Type load error while processing MetadataUpdateOriginalTypeAttribute for {type}", error);`
	`537`	`+ }`
	`538`	`+ hr?.ReportWarning(error);`
	`539`	`+ }`
`532`	`540`	`catch (Exception error)`
`533`	`541`	`{`
`534`	`542`	`if (_log.IsEnabled(LogLevel.Error))`