Thanks to visit codestin.com
Credit goes to github.com

Skip to content

XAML Code gen fail when XAML is invalidΒ #21860

@dr1rrb

Description

@dr1rrb

Current behavior πŸ›

Given

<Page Background="{StaticResource BackgroundColor}" xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:utu="using:Uno.Toolkit.UI" xmlns:sys="using:System">

  <Grid>
    <Grid.RowDefinitions>
      <RowDefinition Height="64" />
      <RowDefinition Height="*" />
      <RowDefinition Height="48" />
    </Grid.RowDefinitions>
    <Grid.ColumnDefinitions>
      <ColumnDefinition Width="*" />
      <ColumnDefinition Width="320" />
    </Grid.ColumnDefinitions>

    <Grid Grid.Row="0" Grid.ColumnSpan="2" Background="{StaticResource PrimaryColor}" Padding="16,16,16,16" VerticalAlignment="Center">
      <Grid.ColumnDefinitions>
        <ColumnDefinition Width="*" />
        <ColumnDefinition Width="Auto" />
      </Grid.ColumnDefinitions>

      <StackPanel Orientation="Vertical">
        <TextBlock x:Uid="EmptyPage.Header.Title" Text="{Binding Repo.Name}" Style="{StaticResource MaterialTitleLarge}" Foreground="{StaticResource OnPrimaryColor}" />
        <TextBlock x:Uid="EmptyPage.Header.Subtitle" Text="{Binding Repo.Description}" Style="{StaticResource MaterialBodySmall}" Foreground="{StaticResource OnPrimaryColor}" Opacity="0.9" />
      </StackPanel>

      <StackPanel Grid.Column="1" Orientation="Horizontal" HorizontalAlignment="Right" VerticalAlignment="Center" Spacing="12">
        <Button x:Uid="EmptyPage.Header.Open" Style="{StaticResource MaterialFilledButtonStyle}" Command="{Binding OpenRepoCommand}" MinHeight="40" MinWidth="120" HorizontalAlignment="Right">
          <StackPanel Orientation="Horizontal" HorizontalAlignment="Center" VerticalAlignment="Center" Spacing="8">
            <SymbolIcon Symbol="OpenLocal" />
            <TextBlock Text="Open on GitHub" />
          </StackPanel>
        </Button>
      </StackPanel>
    </Grid>

    <ScrollViewer Grid.Row="1" Grid.Column="0" Padding="16,16,16,16" HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto">
      <utu:AutoLayout Orientation="Vertical" Spacing="16" Padding="0,0,0,0">
        <utu:CardContentControl Style="{StaticResource MaterialElevatedCardContentControlStyle}" Padding="16,16,16,16" MinHeight="96">
          <utu:AutoLayout Orientation="Vertical" Spacing="8">
            <TextBlock Text="{Binding Repo.Name}" Style="{StaticResource MaterialTitleMedium}" />
            <TextBlock Text="{Binding Repo.Description}" Style="{StaticResource MaterialBodyMedium}" TextWrapping="Wrap" />
            <utu:AutoLayout Orientation="Horizontal" Spacing="8" Justify="SpaceBetween" CounterAxisAlignment="Center">
              <StackPanel Orientation="Horizontal" Spacing="8">
                <Button x:Uid="EmptyPage.Hero.Clone" Style="{StaticResource MaterialOutlinedButtonStyle}" Command="{Binding CloneCommand}" MinHeight="40">
                  <StackPanel Orientation="Horizontal" Spacing="8"><SymbolIcon Symbol="Download" /><TextBlock Text="Clone" /></StackPanel>
                </Button>
                <Button x:Uid="EmptyPage.Hero.Star" Style="{StaticResource MaterialOutlinedButtonStyle}" Command="{Binding StarCommand}" MinHeight="40">
                  <StackPanel Orientation="Horizontal" Spacing="8"><SymbolIcon Symbol="Favorite" /><TextBlock Text="Star" /></StackPanel>
                </Button>
              </StackPanel>
              <StackPanel Orientation="Horizontal" Spacing="8">
                <Button x:Uid="EmptyPage.Hero.Refresh" Style="{StaticResource MaterialFilledButtonStyle}" Command="{Binding RefreshCommand}" MinHeight="40">
                  <StackPanel Orientation="Horizontal" Spacing="8"><SymbolIcon Symbol="Sync" /><TextBlock Text="Refresh" /></StackPanel>
                </Button>
              </StackPanel>
            </utu:AutoLayout>
          </utu:AutoLayout>
        </utu:CardContentControl>

        <ItemsControl ItemsSource="{Binding Metrics}">
          <ItemsControl.ItemsPanel>
            <ItemsPanelTemplate>
              <utu:AutoLayout Orientation="Horizontal" Spacing="16" CounterAxisAlignment="Stretch" />
            </ItemsPanelTemplate>
          </ItemsControl.ItemsPanel>
          <ItemsControl.ItemTemplate>
            <DataTemplate>
              <utu:CardContentControl Style="{StaticResource MaterialElevatedCardContentControlStyle}" Padding="12,12,12,12" MinWidth="280" MaxWidth="480">
                <utu:AutoLayout Orientation="Vertical" Spacing="8">
                  <TextBlock Text="{Binding Title}" Style="{StaticResource MaterialLabelLarge}" />
                  <TextBlock Text="{Binding Value}" Style="{StaticResource MaterialTitleLarge}" />
                  <TextBlock>
                    <Run Text="{Binding Delta}" />
                    <Run Text=" " />
                    <Run Text="{Binding DeltaLabel}" />
                  </TextBlock>
                </utu:AutoLayout>
              </utu:CardContentControl>
            </DataTemplate>
          </ItemsControl.ItemTemplate>
        </ItemsControl>

        <TextBlock Text="Recent Activity" Style="{StaticResource MaterialTitleSmall}" Margin="0,8,0,0" />
        <ListView ItemsSource="{Binding ActivityItems}" Style="{StaticResource MaterialListViewStyle}" IsItemClickEnabled="True">
          <ListView.ItemTemplate>
            <DataTemplate>
              <utu:CardContentControl Style="{StaticResource MaterialElevatedCardContentControlStyle}" Padding="12,12,12,12" MinHeight="64">
                <Grid>
                  <Grid.ColumnDefinitions>
                    <ColumnDefinition Width="*" />
                    <ColumnDefinition Width="Auto" />
                  </Grid.ColumnDefinitions>
                  <StackPanel Orientation="Vertical">
                    <TextBlock Text="{Binding Title}" Style="{StaticResource MaterialBodyMedium}" TextWrapping="Wrap" />
                    <TextBlock Text="{Binding Subtitle}" Style="{StaticResource MaterialCaptionSmall}" Opacity="0.8" />
                  </StackPanel>
                  <StackPanel Grid.Column="1" Orientation="Horizontal" Spacing="8" VerticalAlignment="Center">
                    <Button Style="{StaticResource MaterialTextButtonStyle}" Command="{Binding OpenItemCommand RelativeSource={RelativeSource AncestorType=Page}}" CommandParameter="{Binding}" MinHeight="36">
                      <SymbolIcon Symbol="OpenLocal" />
                    </Button>
                    <Button Style="{StaticResource MaterialTextButtonStyle}" Command="{Binding CommentCommand RelativeSource={RelativeSource AncestorType=Page}}" CommandParameter="{Binding}" MinHeight="36">
                      <SymbolIcon Symbol="Comment" />
                    </Button>
                  </StackPanel>
                </Grid>
              </utu:CardContentControl>
            </DataTemplate>
          </ListView.ItemTemplate>
        </ListView>
      </utu:AutoLayout>
    </ScrollViewer>

    <Border Grid.Row="1" Grid.Column="1" Background="{StaticResource SurfaceVariantColor}" Padding="16,16,16,16">
      <utu:AutoLayout Orientation="Vertical" Spacing="12" CounterAxisAlignment="Stretch">
        <TextBlock Text="Actions" Style="{StaticResource MaterialTitleSmall}" />
        <Button x:Uid="EmptyPage.Rail.NewIssue" Style="{StaticResource MaterialFilledButtonStyle}" Command="{Binding NewIssueCommand}" MinHeight="44">
          <StackPanel Orientation="Horizontal" Spacing="8"><SymbolIcon Symbol="Add" /><TextBlock Text="New Issue" /></StackPanel>
        </Button>
        <Button x:Uid="EmptyPage.Rail.NewPR" Style="{StaticResource MaterialOutlinedButtonStyle}" Command="{Binding NewPRCommand}" MinHeight="44">
          <StackPanel Orientation="Horizontal" Spacing="8"><SymbolIcon Symbol="Add" /><TextBlock Text="New PR" /></StackPanel>
        </Button>
        <Button x:Uid="EmptyPage.Rail.Merge" Style="{StaticResource MaterialFilledButtonStyle}" Command="{Binding MergeCommand}" MinHeight="44">
          <StackPanel Orientation="Horizontal" Spacing="8"><SymbolIcon Symbol="Accept" /><TextBlock Text="Merge" /></StackPanel>
        </Button>
        <Button x:Uid="EmptyPage.Rail.Deploy" Style="{StaticResource MaterialOutlinedButtonStyle}" Command="{Binding DeployCommand}" MinHeight="44">
          <StackPanel Orientation="Horizontal" Spacing="8"><SymbolIcon Symbol="Upload" /><TextBlock Text="Deploy" /></StackPanel>
        </Button>

        <utu:CardContentControl Style="{StaticResource MaterialFilledCardContentControlStyle}" Padding="12,12,12,12" MinHeight="88">
          <utu:AutoLayout Orientation="Vertical" Spacing="6">
            <TextBlock Text="CI Status" Style="{StaticResource MaterialLabelLarge}" />
            <TextBlock Text="{Binding CI.Status}" Style="{StaticResource MaterialBodyMedium}" />
            <ProgressBar Value="{Binding CI.Progress}" Maximum="100" Height="6" Style="{StaticResource MaterialProgressBarStyle}" />
          </utu:AutoLayout>
        </utu:CardContentControl>

        <TextBlock Text="Filters" Style="{StaticResource MaterialLabelSmall}" />
        <StackPanel Orientation="Vertical" Spacing="8">
          <CheckBox Content="Show open only" IsChecked="{Binding Filters.OpenOnly}" />
          <CheckBox Content="Show PRs" IsChecked="{Binding Filters.IncludePRs}" />
        </StackPanel>
      </utu:AutoLayout>
    </Border>

    <Grid Grid.Row="2" Grid.ColumnSpan="2" Background="{StaticResource SurfaceColor}" Padding="16,16,16,16">
      <TextBlock Text="{Binding Repo.Footnote}" Style="{StaticResource MaterialCaptionSmall}" VerticalAlignment="Center" />
    </Grid>
  </Grid>
</Page>

we get:

MainPage_4b7879af665b3f34c1d0fc4a1a361f70.cs (line 2144): error CS1003: Syntax error, ',' expected

Expected behavior 🎯

Expicit error message

How to reproduce it (as minimally and precisely as possible) πŸ”¬

No response

Workaround πŸ› οΈ

No response

Renderer 🎨

  • Skia
  • Native

Affected platforms πŸ“±πŸ’»πŸ–₯️

No response

Uno.Sdk version (and other relevant versions) πŸ“¦

No response

IDE version πŸ§‘β€πŸ’»

No response

Anything else we need to know? πŸ’¬

No response

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions