refactor: Sync DTEHelper with studio repo #21386
Merged
+64
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21386/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21386/docs/index.html |
|
|
5 tasks
Xiaoy312
reviewed
Sep 3, 2025
src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs
Show resolved
Hide resolved
724d045 to
296dc60
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21386/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21386/wasm-skia-net9/index.html |
jeromelaban
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Pull Request Overview
Refactor to sync DTEHelper with studio repo for consistency, bringing improvements to error handling, code style, and method clarity. This is a maintenance update with no functional changes to the API.
- Refactored return type handling and error checking patterns
- Improved method naming and simplified conditional logic
- Applied consistent code style formatting
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Uno.UI.RemoteControl.VS/Helpers/DTEHelper.cs | Updated return types, simplified conditional logic, and added discard patterns for ignored return values |
| src/Uno.UI.RemoteControl.VS/EntryPoint.cs | Renamed method call to improve clarity of purpose |
| src/Uno.UI.RemoteControl.VS/EntryPoint.ActiveProfileSync.cs | Renamed methods for clarity and restructured conditional logic with early returns |
| src/Uno.UI.RemoteControl.Server/Helpers/ServiceCollectionExtensions.cs | Minor formatting improvement for method call |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21386/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21386/docs/index.html |
|
The build 175274 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Refactoring (no functional changes, no api changes)
Sync DTEHelper with studio repo
What is the current behavior? 🤔
Out of sync
What is the new behavior? 🚀
🙃
PR Checklist ✅
Screenshots Compare Test Runresults.Other information ℹ️
Contains changes fo #21292 that has to be merged first