Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(win32): add support IDataObjectAsyncCapability Drag&Drop operations #22182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ramezgerges merged 9 commits into from
Dec 19, 2025
Merged

feat(win32): add support IDataObjectAsyncCapability Drag&Drop operations #22182

ramezgerges merged 9 commits into from
Dec 19, 2025

Conversation

@ramezgerges
Copy link
Contributor

@ramezgerges ramezgerges commented Dec 19, 2025

GitHub Issue: closes https://github.com/unoplatform/kahua-private/issues/390

PR Type:

What is the current behavior? 🤔

What is the new behavior? 🚀

PR Checklist ✅

Please check if your PR fulfills the following requirements:

Other information ℹ️

Copilot AI review requested due to automatic review settings December 19, 2025 01:18
Copilot AI reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for IDataObjectAsyncCapability to enable asynchronous drag-and-drop operations on Win32 platforms, specifically for file drop (HDROP) operations. The feature addresses scenarios where file information becomes available asynchronously during drag-and-drop, such as when dragging files from cloud storage providers.

Key Changes:

  • Refactored Win32ClipboardExtension.GetFileDropList() to return a list instead of directly modifying the DataPackage, enabling reuse in async scenarios
  • Implemented async HDROP handling through a new AsyncHDropHandler class that uses IDataObjectAsyncCapability APIs
  • Added support for querying and displaying custom clipboard format names for improved logging

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.

File Description
src/Uno.UI.Runtime.Skia.Win32/ApplicationMode/DataTransfer/Win32ClipboardExtension.cs Refactored GetFileDropList to return List<IStorageItem>? instead of void, enabling reuse for async file drop operations
src/Uno.UI.Runtime.Skia.Win32/ApplicationMode/DataTransfer/DragDrop/Win32DragDropExtension.cs Added async capability support with TryHandleAsyncHDrop method, AsyncHDropHandler class, and lifecycle management for async file drops
src/Uno.UI.Runtime.Skia.Win32.Support/NativeMethods.txt Added IDataObjectAsyncCapability interface and GetClipboardFormatName function to native method declarations

@ramezgerges ramezgerges force-pushed the outlook_chrome_drag_drop branch from 42c456c to 43f8530 Compare December 19, 2025 15:35
@unodevops
Copy link
Contributor

unodevops commented Dec 19, 2025

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22182/wasm-skia-net9/index.html

Copilot AI review requested due to automatic review settings December 19, 2025 16:02
@unodevops
Copy link
Contributor

unodevops commented Dec 19, 2025

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22182/docs/index.html

Copilot AI reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

@unodevops
Copy link
Contributor

unodevops commented Dec 19, 2025

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22182/wasm-skia-net9/index.html

MartinZikmund
MartinZikmund approved these changes Dec 19, 2025
View reviewed changes
@unodevops
Copy link
Contributor

unodevops commented Dec 19, 2025

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22182/docs/index.html

@ramezgerges ramezgerges mentioned this pull request Dec 19, 2025
Open
2 tasks
@unodevops
Copy link
Contributor

unodevops commented Dec 19, 2025

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22182/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

unodevops commented Dec 19, 2025

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22182/docs/index.html

@unodevops
Copy link
Contributor

unodevops commented Dec 19, 2025

⚠️⚠️ The build 189218 has failed on Uno.UI - CI.

@ramezgerges ramezgerges merged commit 4570195 into unoplatform:master Dec 19, 2025
53 checks passed
@ramezgerges ramezgerges deleted the outlook_chrome_drag_drop branch December 19, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@MartinZikmund MartinZikmund MartinZikmund approved these changes

Assignees

No one assigned

Labels

kind/documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ramezgerges @unodevops @MartinZikmund