-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Context
Users running on-premises deployments often need to write collector output to a directory on the host node's filesystem. Currently, our local storage option doesn't properly support this use case, as it uses an empty directory volume rather than mounting a host path.
Requirements
- Add a new storage type option called
hostPathin the Helm chart - Rename the existing
localstorage type toemptyDirfor clarity (since it uses an emptyDir volume) - For the new
hostPathtype:- Add a configuration parameter for specifying the host directory path to mount
- Automatically prepend the mounted path to the storage prefix parameter
- Ensure proper volume and volumeMount configuration in the Helm chart
Implementation Details
-
Update
values.yamlto include the new storage type option:storage: type: "s3" # Possible values: "s3", "emptyDir", "hostPath" prefix: "memory-collector-metrics-" hostPath: path: "/mnt/data" # Path on the host to mount
-
Rename the existing
localtype toemptyDirthroughout the codebase- Update documentation to reflect this change
- Ensure backward compatibility or provide migration notes
-
Update the Helm templates to handle the new
hostPathstorage type:- Create the appropriate volumeMount and volume definitions
- Mount the host path to a fixed location in the container (e.g.,
/data) - When
hostPathis selected, automatically prepend the container's mount path to the prefix - For example, if the container mount path is
/dataandstorage.prefixismemory-collector-metrics-, the effective prefix should be/data/memory-collector-metrics-
-
Add validation to ensure the provided paths are valid
-
Update the charts/collector/README.md with examples of using the new storage type:
storage: type: "hostPath" prefix: "memory-collector-metrics-" hostPath: path: "/mnt/collector-data" # Path on the host
Acceptance Criteria
- The Helm chart supports a new
hostPathstorage type - The existing
localtype is renamed toemptyDirfor clarity - When using
hostPath, the mounted directory is automatically prepended to the storage prefix - Documentation is updated to explain the new storage option
- Tests verify the functionality works as expected
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed