From 01e7a625b3a8f053062c6e97c7221a0879541e89 Mon Sep 17 00:00:00 2001
From: Andreas Thomas <dev@chronark.com>
Date: Mon, 19 Dec 2022 13:33:30 +0100
Subject: [PATCH 1/2] fix: smembers generic type

---
 pkg/commands/smembers.ts | 11 ++++++-----
 pkg/pipeline.ts          |  5 +++--
 pkg/redis.ts             |  5 +++--
 3 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/pkg/commands/smembers.ts b/pkg/commands/smembers.ts
index a3b38e3b..e69fa389 100644
--- a/pkg/commands/smembers.ts
+++ b/pkg/commands/smembers.ts
@@ -3,11 +3,12 @@ import { Command, CommandOptions } from "./command.ts";
 /**
  * @see https://redis.io/commands/smembers
  */
-export class SMembersCommand<TData = string> extends Command<
-  unknown[],
-  TData[]
-> {
-  constructor(cmd: [key: string], opts?: CommandOptions<unknown[], TData[]>) {
+export class SMembersCommand<TData extends unknown[] = string[]>
+  extends Command<
+    unknown[],
+    TData
+  > {
+  constructor(cmd: [key: string], opts?: CommandOptions<unknown[], TData>) {
     super(["smembers", ...cmd], opts);
   }
 }
diff --git a/pkg/pipeline.ts b/pkg/pipeline.ts
index 311842f6..c98fc571 100644
--- a/pkg/pipeline.ts
+++ b/pkg/pipeline.ts
@@ -778,8 +778,9 @@ export class Pipeline {
   /**
    * @see https://redis.io/commands/smembers
    */
-  smembers = (...args: CommandArgs<typeof SMembersCommand>) =>
-    this.chain(new SMembersCommand(args, this.commandOptions));
+  smembers = <TData extends unknown[] = string[]>(
+    ...args: CommandArgs<typeof SMembersCommand>
+  ) => this.chain(new SMembersCommand<TData>(args, this.commandOptions));
 
   /**
    * @see https://redis.io/commands/smove
diff --git a/pkg/redis.ts b/pkg/redis.ts
index a64d3d88..19d71ac9 100644
--- a/pkg/redis.ts
+++ b/pkg/redis.ts
@@ -750,8 +750,9 @@ export class Redis {
   /**
    * @see https://redis.io/commands/smembers
    */
-  smembers = (...args: CommandArgs<typeof SMembersCommand>) =>
-    new SMembersCommand(args, this.opts).exec(this.client);
+  smembers = <TData extends unknown[] = string[]>(
+    ...args: CommandArgs<typeof SMembersCommand>
+  ) => new SMembersCommand<TData>(args, this.opts).exec(this.client);
 
   /**
    * @see https://redis.io/commands/smove

From 51c3d85d9aaa856ac0422541c31a59e3bc8afe6e Mon Sep 17 00:00:00 2001
From: Andreas Thomas <dev@chronark.com>
Date: Mon, 19 Dec 2022 13:38:29 +0100
Subject: [PATCH 2/2] test: fix types

---
 pkg/commands/smembers.test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pkg/commands/smembers.test.ts b/pkg/commands/smembers.test.ts
index 0b8d479e..87e52292 100644
--- a/pkg/commands/smembers.test.ts
+++ b/pkg/commands/smembers.test.ts
@@ -14,7 +14,7 @@ Deno.test("returns all members of the set", async () => {
   const value2 = { v: randomID() };
 
   await new SAddCommand([key, value1, value2]).exec(client);
-  const res = await new SMembersCommand<{ v: string }>([key]).exec(client);
+  const res = await new SMembersCommand<{ v: string }[]>([key]).exec(client);
 
   assertEquals(res!.length, 2);
   assertEquals(res!.map(({ v }) => v).includes(value1.v), true);