Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: urfave/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.18.1
Choose a base ref
...
head repository: urfave/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.18.2
Choose a head ref
  • 7 commits
  • 4 files changed
  • 2 contributors

Commits on Oct 6, 2022

  1. Add DestinationPointer for flags generator 

    In this commit I added a DestinationPointer variable that should be set
if the `Destination` should be configured as a pointer for a specific
flag type. It is expected that Generic type which is an interface will
not be a pointer but a struct. Before this change the code compilation
was failing with `type *Generic is pointer to interface, not interface`.

See #1441
    @nkuba @dearchap
    nkuba authored and dearchap committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    891ffb0 View commit details
    Browse the repository at this point in the history

  2. Set destination in GenericFlag apply function 

    The function was missing destination configuration.
    @nkuba @dearchap
    nkuba authored and dearchap committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a2541e0 View commit details
    Browse the repository at this point in the history

  3. Add unit test for GenericFlag Destination parsing 

    The test checks if Destination provided in GenericFlag is being set as
expected.
    @nkuba @dearchap
    nkuba authored and dearchap committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    c472192 View commit details
    Browse the repository at this point in the history

  4. After rebase

    @dearchap
    dearchap committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    d724a63 View commit details
    Browse the repository at this point in the history

  5. Fix compile

    @dearchap
    dearchap committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a9c758e View commit details
    Browse the repository at this point in the history

  6. Revert main_test

    @dearchap
    dearchap committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    67f293a View commit details
    Browse the repository at this point in the history

  7. Merge pull request #1442 from nkuba/generit-flag-destination-pointer 

    Configure GenericFlag's Destination type as struct not pointer
    @dearchap
    dearchap authored Oct 6, 2022
    Configuration menu
    Copy the full SHA
    8f469ab View commit details
    Browse the repository at this point in the history
Loading