Install auto #31
Open
Install auto #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey Thanks for the contribution been a while since last time I checked the repo |
drissboumlik
reviewed
Nov 2, 2025
Comment on lines
+57
to
+67
| if ($version -eq 'auto') { | ||
| $result = Auto-Select-PHP-Version | ||
|
|
||
| if ($result.code -eq 0) { | ||
| $version = $result.version | ||
| Display-Msg-By-ExitCode -result $result -message "php $version is already installed!" | ||
| return -1 | ||
| } | ||
|
|
||
| $version = $result.version | ||
| } |
Collaborator
There was a problem hiding this comment.
can you please write a test covering the new added block on router.ps1
here is the file : router.tests.ps1
Contributor
Author
|
I'll get to it whenever I got some time.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect and install the version specified on current project.