Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate fipy.steppers in favor of steppyngstounes #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 65 commits into from
Jun 5, 2025
Merged

Deprecate fipy.steppers in favor of steppyngstounes #777

merged 65 commits into from
Jun 5, 2025

Conversation

@guyer
Copy link
Member

@guyer guyer commented Jan 28, 2021

The fipy.steppers classes were never documented and extremely rarely used.

On the plus side, they didn't work very well.

The whole thing has been refactored as steppyngstounes and examples have been added in examples.phase.binary and examples.phase.binaryCoupled.

Fixes #620

@guyer guyer mentioned this pull request Nov 23, 2021
Closed
guyer added 23 commits April 29, 2025 21:14
@guyer
Convert binary phase field example to use steppyngstounes
40f997d
@guyer
Convert to quadratic time stepper for very long times
d58091f
@guyer
Visualize interface position
bc28225
@guyer
Add discussion of binary phase field behavior
3cfb38e
@guyer
Add mass conservation to step size control
d078ffb
@guyer
Reduce simulation time
5098b16 
It's done for all intents and purposes
@guyer
Create a custom viewer
b76d930
@guyer
Correct description of time steps
30c3916 
Time steps increase geometrically, not parabolically.
Parabolically increasing timesteps (`dt0 * (n/2)**2`) do not
perform as well.
@guyer
Explain merits of steppyngstounes
0868084
@guyer
Apply steppyngstounes to binaryCoupled
338e1a6
@guyer
Update figures for binary phase field examples
750f4d9
@guyer
Revise description of solidification evolution
51a137c
@guyer
Deprecate fipy.steppers
83199cf 
Can't deprecate base class for some reason. Don't really need to.
@guyer
Add discussion of adaptive stepping to USAGE
ce6133c
@guyer
Fix spelling errors
644fc3d
@guyer
Discard result of succeeded()
d3d138b
@guyer
Fix typo
c6f2988
@guyer
Fix math
4a21e71
@guyer
Ensure mass conservation of early evolution
d7aee09
@guyer
Fix LaTeX
538ae36
@guyer
Fix LaTeX
03c29ae
@guyer
ping the build
52193fc
@guyer
Update lock files to include steppyngstounes
40879d5
@guyer guyer force-pushed the issue620-Working_example_of_adaptive_stepper-use_steppyngstounes branch from 5ef6bac to 40879d5 Compare May 1, 2025 13:55
guyer added 7 commits June 2, 2025 16:08
@guyer
Add script to enable use of siunitx from mathjax
214a9fd 
Uses https://github.com/limefrogyank/siunitx-pcc
@guyer
Replace \qty with \unit
c45e52e 
TeX-Live loaded by GHActions/Docs4NIST is really old and doesn't
have \qty command.
@guyer
Remove siunitx \unit command
9d9b064 
TeX-Live version doesn't seem to understand anything
@guyer
Convert siunitx commands to mathrm
8878662 
Can't get the ancient version of siunitx in the Docs4NIST Docker
image to work right.
@guyer
Convert siunitx commands to mathrm (bis)
50cbcf7
@guyer
Bump deprecation version
4326894
@guyer
Convert siunitx commands to mathrm (bis) (bis)
c092ea7
@guyer guyer marked this pull request as ready for review June 2, 2025 22:26
@guyer guyer requested review from tkphd and wd15 June 2, 2025 22:26
@guyer
Copy link
Member Author

guyer commented Jun 2, 2025

@wd15: I could use help figuring out what to do with nix. It's failing because I added steppyngstounes.

This can probably wait until I turn steppyngstounes into a conda-forge package.

guyer added 12 commits June 4, 2025 16:35
@guyer
Add skipper if steppyngstounes isn't installed
6c32528
@guyer
Update environments to use steppyngstounes from PyPI
e732c9d
@guyer
Update locks to use steppyngstounes from conda-forge
df22f24 
Even though steppyngstounes is noarch and works back to Python 2.7,
conda-forge feedstock recipes don't seem to accomodate that
very well.
Easier to just install it from pip for the more bit-rotty solver suites.
@guyer
Fix exclamation mark in x264 lock
847cf82
@guyer
Fix path to ignore
a4cb52d
@guyer
Ignore quality check for code that isn't ours
517ffd9
@guyer
Revert "Add script to enable use of siunitx from mathjax"
d4746e3 
This reverts commit 214a9fd.
@guyer
Revert "Switch from SIunits to siunitx"
e1c7837 
This reverts commit a85b12d.
@guyer
Revert "Ignore quality check for code that isn't ours"
2e08ada 
This reverts commit 517ffd9.
@guyer
Revert "Remove LaTeX commands that MathJax can't render"
b7a575e 
This reverts commit 0a3c7e5.
@guyer
Revert "Enable Sphinx' MathJax support"
01a937e 
This reverts commit fdf545b.
@guyer
Revert "ping the build"
27066c2 
This reverts commit 52193fc.
wd15
wd15 approved these changes Jun 5, 2025
View reviewed changes
@wd15
Copy link
Contributor

wd15 commented Jun 5, 2025

I couldn't find any issues in the two rendered examples.

@guyer guyer merged commit 0dcc3e9 into usnistgov:master Jun 5, 2025
22 checks passed
@guyer guyer deleted the issue620-Working_example_of_adaptive_stepper-use_steppyngstounes branch June 5, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wd15 wd15 wd15 approved these changes

@tkphd tkphd Awaiting requested review from tkphd

Assignees

No one assigned

Labels

documentation enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Working example of adaptive stepper (pidStepper)

2 participants

@guyer @wd15