Thanks to visit codestin.com
Credit goes to github.com

Skip to content

USWDS - Bug: Banner & Footer style conflict caused by removing layout-grid dependency. #5914

@mahoneycm

Description

@mahoneycm

Describe the bug

When forwarding usa-banner & usa-footer packages and not the usa-layout-grid package, there are visual regressions within the banner.

This is caused by the new layout grid styles added to the footer stylesheet in #5675

Steps to reproduce the bug

  1. Add banner and footer to a page.
  2. Remove all other packages or @forward "uswds" from styles.scss file.
  3. Only import usa-banner & usa-footer.
  4. Compile and inspect display of the banner component.

Expected Behavior

Banner and footer should display as expected without forwarding the layout grid package

Related code

styles.scss

@forward "uswds-theme";
@forward "usa-banner";
@forward "usa-footer";
@forward "uswds-theme-custom-styles";

This seems to be the definition that is causing the visual regression

// Columns
[class*="grid-col"] {
@include u-position(relative);
@include u-width(full);
box-sizing: border-box;
}

Screenshots

image

System setup

No response

Additional context

No response

Code of Conduct

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions