-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
Added during SprintContext: SassIssue is in SassIssue is in SassPackage: FooterRole: DevDevelopment/engineering skills neededDevelopment/engineering skills needed
Description
Describe the bug
When forwarding usa-banner & usa-footer packages and not the usa-layout-grid package, there are visual regressions within the banner.
This is caused by the new layout grid styles added to the footer stylesheet in #5675
Steps to reproduce the bug
- Add banner and footer to a page.
- Remove all other packages or
@forward "uswds"fromstyles.scssfile. - Only import
usa-banner&usa-footer. - Compile and inspect display of the banner component.
Expected Behavior
Banner and footer should display as expected without forwarding the layout grid package
Related code
styles.scss
@forward "uswds-theme";
@forward "usa-banner";
@forward "usa-footer";
@forward "uswds-theme-custom-styles";This seems to be the definition that is causing the visual regression
uswds/packages/usa-footer/src/styles/_usa-footer.scss
Lines 56 to 62 in 88a1130
| // Columns | |
| [class*="grid-col"] { | |
| @include u-position(relative); | |
| @include u-width(full); | |
| box-sizing: border-box; | |
| } | |
Screenshots
System setup
No response
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct.
- I checked the current issues for duplicate bug reports.
Metadata
Metadata
Assignees
Labels
Added during SprintContext: SassIssue is in SassIssue is in SassPackage: FooterRole: DevDevelopment/engineering skills neededDevelopment/engineering skills needed
Type
Projects
Status
Done