Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Oct 31, 2023

Summary

Changelogs for all updates in the USWDS 3.7.0 release.

Preview links

@amyleadem amyleadem marked this pull request as ready for review November 6, 2023 17:43
Amy Leadem and others added 2 commits November 6, 2023 10:51
@amyleadem amyleadem added this to the uswds 3.7.0 milestone Nov 6, 2023
@amyleadem amyleadem self-assigned this Nov 6, 2023
@amyleadem
Copy link
Contributor Author

@thisisdano I confirmed the following items:

  • Confirmed that all 3.7.0 items have related documentation updates
  • Confirmed that changelogs are written in past tense and have periods.
  • Confirmed changelog information is accurate.
  • Confirmed that the changelog item tags are appropriate
  • Confirmed that changelog dates and version numbers have been updated
    • Not done yet
  • Confirmed that all references to node version 16.18.0 have been updated to 20.9.0
    • Added a comment about a possible edit to the README

Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs look good to me! I think we should update the Node version in the README then this should get the green stamp 👍

  • Changelogs are accurate
  • PR numbers are correct
  • No spelling or grammar issues!

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good and all changes seem to be captured.

@mejiaj mejiaj requested a review from mahoneycm November 8, 2023 20:17
type: component
changelogURL:
items:
- date: 2023-11-9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other release dates on the 9th of the month have a leading zero

Suggested change
- date: 2023-11-9
- date: 2023-11-09

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@thisisdano thisisdano merged commit 3111955 into main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants