feat(types): simplify ExtractPropTypes to avoid props JSDocs being removed
#5166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate issues: vuejs/language-tools#799, microsoft/TypeScript#31992
Remove
O extends objectfromExtractPropTypesto avoid tsc remove props JSDoc comments.And it can also help for improve component props hover info in IDE.
In addition, changed{ [K in KeysType]: T[K] }to{ [K in keyof Pick<K, KeysType>]: T[K] }to fixed find references, renaming not working for props again. (#3656)Revert this change from
LooseRequiredbecause it cause tests failed.Before simplify
ExtractPropTypes:After simplify
ExtractPropTypes: